Skip to content

Cleanup outputTaskFailureListeners on query complete #20023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sopel39 merged 1 commit into from
Dec 5, 2023
Merged

Cleanup outputTaskFailureListeners on query complete #20023

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion core/trino-main/src/main/java/io/trino/execution/QueryStateMachine.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1523,14 +1523,17 @@ public synchronized void setQueryCompleted()
}
queryCompleted = true;
inputsQueue.clear();
outputTaskFailureListeners.clear();
noMoreInputs = true;
}

public void addOutputTaskFailureListener(TaskFailureListener listener)
{
Map<TaskId, Throwable> failures;
synchronized (this) {
outputTaskFailureListeners.add(listener);
if (!queryCompleted) {
Comment thread
losipiuk marked this conversation as resolved.
Outdated
outputTaskFailureListeners.add(listener);
}
failures = ImmutableMap.copyOf(outputTaskFailures);
}
if (!failures.isEmpty()) {
Expand All @@ -1542,6 +1545,10 @@ public void outputTaskFailed(TaskId taskId, Throwable failure)
{
List<TaskFailureListener> listeners;
synchronized (this) {
if (queryCompleted) {
// ignore late task failed events after query is completed
return;
}
outputTaskFailures.putIfAbsent(taskId, failure);
listeners = ImmutableList.copyOf(outputTaskFailureListeners);
}
Expand Down