Cleanup outputTaskFailureListeners on query complete#20023
Merged
sopel39 merged 1 commit intotrinodb:masterfrom Dec 5, 2023
Merged
Cleanup outputTaskFailureListeners on query complete#20023sopel39 merged 1 commit intotrinodb:masterfrom
sopel39 merged 1 commit intotrinodb:masterfrom
Conversation
Member
Author
|
Related to #20022 |
losipiuk
reviewed
Dec 5, 2023
core/trino-main/src/main/java/io/trino/execution/QueryStateMachine.java
Outdated
Show resolved
Hide resolved
losipiuk
approved these changes
Dec 5, 2023
outputTaskFailureListeners were referencing QueryScheduler which are retaining references to HttpRemoteTask instances and other query runtime objects. This was considered a memory leak.
sopel39
force-pushed
the
ks/cleanup_listeners
branch
from
e5dec7d to
210c2b2
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
outputTaskFailureListeners were referencing QueryScheduler which are retaining references to HttpRemoteTask instances and other query runtime objects. This was considered a memory leak.
Before:
After this PR references to
HttpRemoteTaskare gone