Skip to content

Ensure taskInfo finalized on permanent worker failure #20021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
losipiuk merged 1 commit into from
Dec 5, 2023
Merged

Ensure taskInfo finalized on permanent worker failure #20021

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions core/trino-main/src/main/java/io/trino/server/remotetask/HttpRemoteTask.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1057,6 +1057,14 @@ private synchronized void fatalUnacknowledgedFailure(Throwable cause)
taskStatusFetcher.updateTaskStatus(taskStatus);
}
}
else {
// Even though state in taskStatus is Done already it could not be the case for task info.
// We could have received valid response from taskStatusFetcher just before the worker went
// down, but taskInfoFetcher still holds old state.
// Update taskInfo so task is not stuck in FTE execution mode which depends on final task info
// being delivered.
updateTaskInfo(getTaskInfo().withTaskStatus(taskStatus));
}
}
}

Expand Down