Ensure taskInfo finalized on permanent worker failure#20021
Merged
losipiuk merged 1 commit intotrinodb:masterfrom Dec 5, 2023
Merged
Ensure taskInfo finalized on permanent worker failure#20021losipiuk merged 1 commit intotrinodb:masterfrom
losipiuk merged 1 commit intotrinodb:masterfrom
Conversation
Even though state in taskStatus is Done already it could not be the case for task info. We could have received valid response from taskStatusFetcher just before the worker went down, but taskInfoFetcher still holds old state. Update taskInfo so task is not stuck in FTE execution mode which depends on final task info being delivered.
sopel39
approved these changes
Dec 5, 2023
Member
sopel39
left a comment
sopel39
left a comment
There was a problem hiding this comment.
nit: maybe test in TestHttpRemoteTask?
pettyjamesm
approved these changes
Dec 5, 2023
This was referenced Oct 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Even though state in taskStatus is Done already it could not be the case for task info.
We could have received valid response from taskStatusFetcher just before the worker went
down, but taskInfoFetcher still holds old state.
Update taskInfo so task is not stuck in FTE execution mode which depends on final task info
being delivered.
#fixes #18603
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text: