Skip to content

Move formatting out from ParquetCorruptionException#19907

Closed
ksobolew wants to merge 1 commit intotrinodb:masterfrom
ksobolew:kudi/error-prone-annotate-format-method-remnants
Closed

Move formatting out from ParquetCorruptionException#19907
ksobolew wants to merge 1 commit intotrinodb:masterfrom
ksobolew:kudi/error-prone-annotate-format-method-remnants

Conversation

@ksobolew
Copy link
Contributor

@ksobolew ksobolew commented Nov 27, 2023

Description

...to its callers, to make the exception class more focused. This in fact makes it consistent with how other exception classes were transformed, though I don't remember the exact commits right now.

Additional context and related issues

These are the remnants of #14933 and #15963 (and kind of #15052 too) after #19899 (specifically f3c803e) made them mostly obsolete.

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label Nov 27, 2023
@github-actions github-actions bot added tests:hive hive Hive connector labels Nov 27, 2023
@ksobolew ksobolew force-pushed the kudi/error-prone-annotate-format-method-remnants branch from 3089cdd to 27b5387 Compare November 27, 2023 17:20
@ksobolew
Copy link
Contributor Author

CI: #16315

@ksobolew ksobolew force-pushed the kudi/error-prone-annotate-format-method-remnants branch from 27b5387 to edd6722 Compare November 28, 2023 16:15
@ksobolew ksobolew changed the title Annotate additional methods with FormatMethod Some follow-ups to annotating format methods Nov 28, 2023
@github-actions
Copy link

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua

@github-actions github-actions bot added the stale label Jan 10, 2024
@mosabua
Copy link
Member

mosabua commented Jan 11, 2024

👋 @ksobolew I assume you will continue work on this PR and will leave it open.

@ksobolew
Copy link
Contributor Author

@mosabua I don't know, from my point of view it's "done", but perhaps it doesn't bring enough value.

@mosabua
Copy link
Member

mosabua commented Jan 12, 2024

@findepi you already reviewed a bit. Whats your opinion .. complete to merge or close?

@github-actions github-actions bot removed the stale label Jan 12, 2024
...to its callers, to make the exception class more focused.
@ksobolew ksobolew force-pushed the kudi/error-prone-annotate-format-method-remnants branch from edd6722 to f45f211 Compare February 2, 2024 10:24
@ksobolew ksobolew changed the title Some follow-ups to annotating format methods Move formatting out from ParquetCorruptionException Feb 2, 2024
@github-actions
Copy link

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua

@github-actions github-actions bot added stale and removed stale labels Feb 28, 2024
@github-actions
Copy link

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua

@github-actions github-actions bot added the stale label Mar 21, 2024
@github-actions
Copy link

Closing this pull request, as it has been stale for six weeks. Feel free to re-open at any time.

@github-actions github-actions bot closed this Apr 11, 2024
@mosabua
Copy link
Member

mosabua commented Apr 11, 2024

@findepi I am leaving this closed .. feel free to reopen and merge if its good to go

@ksobolew ksobolew deleted the kudi/error-prone-annotate-format-method-remnants branch March 25, 2025 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants