Annotate semanticException factories as format methods#15963
Closed
ksobolew wants to merge 3 commits intotrinodb:masterfrom
Closed
Annotate semanticException factories as format methods#15963ksobolew wants to merge 3 commits intotrinodb:masterfrom
ksobolew wants to merge 3 commits intotrinodb:masterfrom
Conversation
ksobolew
changed the title
findepi
reviewed
Feb 3, 2023
Member
There was a problem hiding this comment.
is it because one @FormatMethod cannot delegate to other @FormatMethod?
if so, seems like error-prone's bug to me
Contributor
Author
There was a problem hiding this comment.
It can, but looks like it gets confused by them being different types. I wasn't sure if this is a bug or a weird corner case.
Member
There was a problem hiding this comment.
it doesn't look like we were doing anything wrong here
Contributor
Author
There was a problem hiding this comment.
The actual message is:
java: [FormatStringAnnotation] The format argument types passed with an @FormatString must match the types of the format arguments in the @FormatMethod header where the format string was declared.
Format arg types passed: [io.trino.spi.type.Type, io.trino.spi.type.Type]
Format arg types expected: [io.trino.sql.tree.Expression, io.trino.sql.tree.Expression]
Thing is, the message is the same but the message arguments passed to semanticException are not the same as the parameters of the enclosing method. So it kinda sorta makes sense?
ksobolew
force-pushed
the
kudi/error-prone-format-method-semantic-exception
branch
3 times, most recently
from
e085a75 to
96fec41
Compare
Contributor
Author
|
|
ksobolew
force-pushed
the
kudi/error-prone-format-method-semantic-exception
branch
from
96fec41 to
024dee9
Compare
|
This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua |
This method is unusual in that it takes a error message as a format string and exactly two arguments; the annotation will make sure that the format string will also be valid for exactly two arguments.
This makes it consistent with the rest of the method, where all the error messages have the property name.
This annotation allows more cases to be checked by the `FormatStringAnnotation` checker. Fixes up all the trivial cases where they can be used as a format methods but weren't.
ksobolew
force-pushed
the
kudi/error-prone-format-method-semantic-exception
branch
from
024dee9 to
cc1c2ce
Compare
Contributor
Author
|
Pushed an update with some fresh specimens from a recent large merge. |
Contributor
Author
ksobolew
deleted the
kudi/error-prone-format-method-semantic-exception
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This annotation allows more cases to be checked by the
FormatStringAnnotationchecker. Fixes up all the trivial cases where they can be used as a format methods but weren't.Additional context and related issues
Extracted from #14933.
Release notes
(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: