Skip to content

Fix timestamp precision in Iceberg testTableChangesFunction #19890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
findepi merged 1 commit into from
Nov 28, 2023
Merged

Fix timestamp precision in Iceberg testTableChangesFunction #19890

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions ...in/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergConnectorSmokeTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
import org.junit.jupiter.api.Timeout;

import java.time.ZonedDateTime;
import java.time.format.DateTimeFormatter;
import java.util.List;
import java.util.Optional;
import java.util.concurrent.CyclicBarrier;
Expand All @@ -53,7 +54,7 @@
import static io.trino.testing.TestingConnectorSession.SESSION;
import static io.trino.testing.TestingNames.randomNameSuffix;
import static java.lang.String.format;
import static java.time.format.DateTimeFormatter.ISO_INSTANT;
import static java.time.ZoneOffset.UTC;
import static java.util.Objects.requireNonNull;
import static java.util.concurrent.Executors.newFixedThreadPool;
import static java.util.concurrent.TimeUnit.SECONDS;
Expand Down Expand Up @@ -727,14 +728,16 @@ public void testPartitionFilterRequired()
@Test
public void testTableChangesFunction()
{
DateTimeFormatter instantMillisFormatter = DateTimeFormatter.ofPattern("uuuu-MM-dd'T'HH:mm:ss.SSSVV").withZone(UTC);

try (TestTable table = new TestTable(
getQueryRunner()::execute,
"test_table_changes_function_",
"AS SELECT nationkey, name FROM tpch.tiny.nation WITH NO DATA")) {
long initialSnapshot = getMostRecentSnapshotId(table.getName());
assertUpdate("INSERT INTO " + table.getName() + " SELECT nationkey, name FROM nation", 25);
long snapshotAfterInsert = getMostRecentSnapshotId(table.getName());
String snapshotAfterInsertTime = getSnapshotTime(table.getName(), snapshotAfterInsert).format(ISO_INSTANT);
String snapshotAfterInsertTime = getSnapshotTime(table.getName(), snapshotAfterInsert).format(instantMillisFormatter);

assertQuery(
"SELECT nationkey, name, _change_type, _change_version_id, to_iso8601(_change_timestamp), _change_ordinal " +
Expand All @@ -743,7 +746,7 @@ public void testTableChangesFunction()

assertUpdate("DELETE FROM " + table.getName(), 25);
long snapshotAfterDelete = getMostRecentSnapshotId(table.getName());
String snapshotAfterDeleteTime = getSnapshotTime(table.getName(), snapshotAfterDelete).format(ISO_INSTANT);
String snapshotAfterDeleteTime = getSnapshotTime(table.getName(), snapshotAfterDelete).format(instantMillisFormatter);

assertQuery(
"SELECT nationkey, name, _change_type, _change_version_id, to_iso8601(_change_timestamp), _change_ordinal " +
Expand Down