Fix timestamp precision in Iceberg testTableChangesFunction#19890
Merged
findepi merged 1 commit intotrinodb:masterfrom Nov 28, 2023
Conversation
findepi
added
test
no-release-notes
The ISO_INSTANT use before the change does not render seconds fraction when it is zero, so the test failed when snapshot happened to be committed at a whole second.
findepi
force-pushed
the
findepi/fix-timestamp-precision-in-iceberg-testtablechangesfunction-3fb4e2
branch
from
5ab4376 to
10bbae6
Compare
ebyhr
approved these changes
Nov 28, 2023
findepi
deleted the
findepi/fix-timestamp-precision-in-iceberg-testtablechangesfunction-3fb4e2
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ISO_INSTANT use before the change does not render seconds fraction when it is zero, so the test failed when snapshot happened to be committed at a whole second.
Fixes #19242