Skip to content

Fix typo in config #19784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
oneonestar wants to merge 1 commit into from
Closed

Fix typo in config #19784

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion core/trino-main/src/main/java/io/trino/execution/QueryManagerConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,7 +265,8 @@ public int getMaxWriterTasksCount()
return maxWriterTasksCount;
}

@Config("query.max-writer-task-count")
Copy link
Copy Markdown
Member

@ebyhr ebyhr Nov 17, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

task-count was intentional. #16238 (comment)
It seems the session property wasn't changed when addressing the comment.

Copy link
Copy Markdown
Member Author

@oneonestar oneonestar Nov 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That doesn't make sense to me.
All the docs, session property, tests and codes are using tasks-count.

@sopel39 Could you take a look on this?

Copy link
Copy Markdown
Member

@sopel39 sopel39 Nov 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems the session property wasn't changed when addressing the comment.

Yes, I think addressing of comment was incomplete. @radek-starburst could you update rest of code (docs, session property)

@Config("query.max-writer-tasks-count")
@LegacyConfig("query.max-writer-task-count")
@ConfigDescription("Maximum number of tasks that will participate in writing data")
public QueryManagerConfig setMaxWriterTasksCount(int maxWritersNodesCount)
{
Expand Down
2 changes: 1 addition & 1 deletion core/trino-main/src/test/java/io/trino/execution/TestQueryManagerConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ public void testExplicitPropertyMappings()
.put("fault-tolerant-execution-runtime-adaptive-partitioning-partition-count", "888")
.put("fault-tolerant-execution-runtime-adaptive-partitioning-max-task-size", "18GB")
.put("fault-tolerant-execution-min-source-stage-progress", "0.3")
.put("query.max-writer-task-count", "101")
.put("query.max-writer-tasks-count", "101")
.put("fault-tolerant-execution-small-stage-estimation-enabled", "false")
.put("fault-tolerant-execution-small-stage-estimation-threshold", "6GB")
.put("fault-tolerant-execution-small-stage-source-size-multiplier", "1.6")
Expand Down