Closed
Conversation
ebyhr
reviewed
Nov 17, 2023
Member
There was a problem hiding this comment.
task-count was intentional. #16238 (comment)
It seems the session property wasn't changed when addressing the comment.
Member
Author
There was a problem hiding this comment.
That doesn't make sense to me.
All the docs, session property, tests and codes are using tasks-count.
@sopel39 Could you take a look on this?
Member
There was a problem hiding this comment.
It seems the session property wasn't changed when addressing the comment.
Yes, I think addressing of comment was incomplete. @radek-starburst could you update rest of code (docs, session property)
Member
Author
|
Succeeded by #19793 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix #19783
Release notes
In the previous release note and documentation the config is correctly written as
query.max-writer-tasks-count.I'm not sure if we need another release note for this typo fix.