Shutdown SplitSource executors during cleanup#19743
Merged
pettyjamesm merged 2 commits intotrinodb:masterfrom Nov 15, 2023
Merged
Shutdown SplitSource executors during cleanup#19743pettyjamesm merged 2 commits intotrinodb:masterfrom
pettyjamesm merged 2 commits intotrinodb:masterfrom
Conversation
pettyjamesm
changed the title
martint
reviewed
Nov 15, 2023
core/trino-main/src/test/java/io/trino/split/TestBufferingSplitSource.java
Outdated
Show resolved
Hide resolved
pettyjamesm
force-pushed
the
cleanup-test-split-source
branch
from
ee1f921 to
9489441
Compare
martint
reviewed
Nov 15, 2023
| @PreDestroy | ||
| public void shutdown() | ||
| { | ||
| executorService.shutdown(); |
Member
There was a problem hiding this comment.
What's the benefit of doing this? The underlying pool uses daemon threads, so they'll all terminate when the VM stops. shutdown() does not wait for or interrupt the threads, so it won't do much except for preventing new tasks from being submitted.
Member
Author
There was a problem hiding this comment.
In a typical deployment situation, this has no effect since the SplitManager is created only once. However, in tests this ensures that the threadpool is shutdown and the threads stopped earlier than they would if the usual cached threadpool 60 second idle timeout is reached.
martint
approved these changes
Nov 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follows up after #19369 and ensures that the new
SplitManagerexecutor is shut down during cleanup so that threads aren't kept around unnecessarily in test environments.Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: