Fix possible StackOverflowError in BufferingSplitSource#19369
Merged
raunaqmorarka merged 2 commits intotrinodb:masterfrom Nov 9, 2023
Merged
Fix possible StackOverflowError in BufferingSplitSource#19369raunaqmorarka merged 2 commits intotrinodb:masterfrom
raunaqmorarka merged 2 commits intotrinodb:masterfrom
Conversation
raunaqmorarka
requested review from
electrum,
findepi,
martint and
pettyjamesm
pettyjamesm
reviewed
Oct 12, 2023
core/trino-main/src/main/java/io/trino/split/BufferingSplitSource.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/split/BufferingSplitSource.java
Outdated
Show resolved
Hide resolved
raunaqmorarka
force-pushed
the
fix-so
branch
2 times, most recently
from
421278a to
b4d43ec
Compare
losipiuk
approved these changes
Nov 6, 2023
sopel39
reviewed
Nov 6, 2023
Member
There was a problem hiding this comment.
could it end up being active loop?
Member
Author
There was a problem hiding this comment.
This code is added to prevent a problem of waiting forever because of splits being produced after a future is already done.
If there is a problem with some test usage, then the test will fail or loop forever.
core/trino-main/src/main/java/io/trino/execution/QueryManagerConfig.java
Outdated
Show resolved
Hide resolved
sopel39
approved these changes
Nov 6, 2023
core/trino-main/src/main/java/io/trino/split/BufferingSplitSource.java
Outdated
Show resolved
Hide resolved
sopel39
approved these changes
Nov 7, 2023
core/trino-main/src/main/java/io/trino/execution/QueryManagerConfig.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/split/BufferingSplitSource.java
Outdated
Show resolved
Hide resolved
pettyjamesm
reviewed
Nov 7, 2023
core/trino-main/src/main/java/io/trino/split/BufferingSplitSource.java
Outdated
Show resolved
Hide resolved
Avoid chaning futures on a directExecutor by submitting requests for fetching splits to a separte thread pool instead
losipiuk
approved these changes
Nov 8, 2023
pettyjamesm
approved these changes
Nov 8, 2023
sopel39
approved these changes
Nov 8, 2023
core/trino-main/src/main/java/io/trino/execution/QueryManagerConfig.java
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Additional context and related issues
Fixes #15073
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: