Skip to content

Increase Spark memory in Delta product test #19714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ebyhr merged 1 commit into from
Nov 13, 2023
Merged

Increase Spark memory in Delta product test #19714

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ...ocker/presto-product-tests/conf/environment/singlenode-delta-lake-oss/spark-defaults.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
# singlenode-delta-lake-oss causes OOM maybe by too many product tests
spark.driver.memory=2g
Copy link
Copy Markdown
Member

@findepi findepi Nov 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any idea why we need this here and not in 8 other spark-defaults.conf files?
let's capture the reasoning in a code comment

Copy link
Copy Markdown
Member Author

@ebyhr ebyhr Nov 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a code comment. There're some differences (Spark version, number of product tests and so on), but I'm not sure about the root cause, to be honest.


spark.sql.catalogImplementation=hive
spark.sql.warehouse.dir=hdfs://hadoop-master:9000/user/hive/warehouse
spark.sql.hive.thriftServer.singleSession=false
Expand Down