Increase Spark memory in Delta product test#19714
Merged
ebyhr merged 1 commit intotrinodb:masterfrom Nov 13, 2023
Merged
Conversation
ebyhr
commented
Nov 13, 2023
Member
Author
There was a problem hiding this comment.
Reminder: Drop this commit.
findinpath
approved these changes
Nov 13, 2023
findepi
approved these changes
Nov 13, 2023
Member
There was a problem hiding this comment.
Any idea why we need this here and not in 8 other spark-defaults.conf files?
let's capture the reasoning in a code comment
Member
Author
There was a problem hiding this comment.
Added a code comment. There're some differences (Spark version, number of product tests and so on), but I'm not sure about the root cause, to be honest.
ebyhr
force-pushed
the
ebi/detal-spark-oom
branch
from
aaf1230 to
7d22ee3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Hopefully, fixes #19602
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.