Skip to content

Use dedicated schemas in Delta Lake smoke tests #19343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ebyhr merged 1 commit into from
Nov 10, 2023
Merged

Use dedicated schemas in Delta Lake smoke tests #19343

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 12 additions & 7 deletions ...o-delta-lake/src/test/java/io/trino/plugin/deltalake/BaseDeltaLakeConnectorSmokeTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -481,20 +481,25 @@ public void testHiddenColumns()
@Test
public void testHiveViewsCannotBeAccessed()
{
String schemaName = "test_schema" + randomNameSuffix();
String viewName = "dummy_view";
hiveHadoop.runOnHive(format("CREATE VIEW %1$s.%2$s AS SELECT * FROM %1$s.customer", SCHEMA, viewName));
assertThatThrownBy(() -> computeActual("DESCRIBE " + viewName)).hasMessageContaining(format("%s.%s is not a Delta Lake table", SCHEMA, viewName));
hiveHadoop.runOnHive("DROP VIEW " + viewName);
hiveHadoop.runOnHive("CREATE DATABASE " + schemaName);
hiveHadoop.runOnHive(format("CREATE VIEW %s.%s AS SELECT * FROM %s.customer", schemaName, viewName, SCHEMA));
assertEquals(computeScalar(format("SHOW TABLES FROM %s LIKE '%s'", schemaName, viewName)), viewName);
assertThatThrownBy(() -> computeActual("DESCRIBE " + schemaName + "." + viewName)).hasMessageContaining(format("%s.%s is not a Delta Lake table", schemaName, viewName));
hiveHadoop.runOnHive("DROP DATABASE " + schemaName + " CASCADE");
}

@Test
public void testNonDeltaTablesCannotBeAccessed()
{
String schemaName = "test_schema" + randomNameSuffix();
String tableName = "hive_table";
hiveHadoop.runOnHive(format("CREATE TABLE %s.%s (id BIGINT)", SCHEMA, tableName));
assertEquals(computeScalar(format("SHOW TABLES LIKE '%s'", tableName)), tableName);
assertThatThrownBy(() -> computeActual("DESCRIBE " + tableName)).hasMessageContaining(tableName + " is not a Delta Lake table");
hiveHadoop.runOnHive(format("DROP TABLE %s.%s", SCHEMA, tableName));
hiveHadoop.runOnHive("CREATE DATABASE " + schemaName);
hiveHadoop.runOnHive(format("CREATE TABLE %s.%s (id BIGINT)", schemaName, tableName));
assertEquals(computeScalar(format("SHOW TABLES FROM %s LIKE '%s'", schemaName, tableName)), tableName);
assertThatThrownBy(() -> computeActual("DESCRIBE " + schemaName + "." + tableName)).hasMessageContaining(tableName + " is not a Delta Lake table");
hiveHadoop.runOnHive("DROP DATABASE " + schemaName + " CASCADE");
}

@Test
Expand Down