Add missing support for bucket sort order in Glue#1870
Merged
sopel39 merged 1 commit intotrinodb:masterfrom Feb 22, 2020
Merged
Add missing support for bucket sort order in Glue#1870sopel39 merged 1 commit intotrinodb:masterfrom
sopel39 merged 1 commit intotrinodb:masterfrom
Conversation
Member
Author
|
We should add Glue tests for these too |
Member
there is |
sopel39
requested review from
anusudarsan and
findepi
and removed request for
electrum
findepi
approved these changes
Feb 22, 2020
| sd.setOutputFormat(storage.getStorageFormat().getOutputFormatNullable()); | ||
| sd.setParameters(ImmutableMap.of()); | ||
|
|
||
| Optional<HiveBucketProperty> bucketProperty = storage.getBucketProperty(); |
Member
|
AFAICT we respect bucket sort order when reading glue table, but worth double checking. |
sopel39
force-pushed
the
ks/missing_glue_support
branch
from
6ac8e3e to
9eed313
Compare
Member
Author
Yes, we do: |
sopel39
force-pushed
the
ks/missing_glue_support
branch
from
9eed313 to
add2034
Compare
Support for bucket sort order was missing in Glue when table or partition was created or updated.
sopel39
force-pushed
the
ks/missing_glue_support
branch
from
add2034 to
4e3a29b
Compare
v-jizhang
added a commit
to v-jizhang/presto
that referenced
this pull request
Apr 26, 2021
Cherry pick of trinodb/trino#1870. Co-authored-by: Karol Sobczak <karol.sobczak@karolsobczak.com>
highker
pushed a commit
to prestodb/presto
that referenced
this pull request
May 20, 2021
Cherry pick of trinodb/trino#1870. Co-authored-by: Karol Sobczak <karol.sobczak@karolsobczak.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.