Add missing support for bucket sort order in Glue#16003
Merged
highker merged 1 commit intoprestodb:masterfrom May 20, 2021
Merged
Add missing support for bucket sort order in Glue#16003highker merged 1 commit intoprestodb:masterfrom
highker merged 1 commit intoprestodb:masterfrom
Conversation
Cherry pick of trinodb/trino#1870. Co-authored-by: Karol Sobczak <karol.sobczak@karolsobczak.com>
aweisberg
approved these changes
May 12, 2021
Contributor
aweisberg
left a comment
aweisberg
left a comment
There was a problem hiding this comment.
LGTM.
It's a bit scary merging this when the Glue integration tests aren't running :-(
I'll bring it up at the next sync. Glue/S3 seems too important for that to continue.
highker
approved these changes
May 20, 2021
10 tasks
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry pick of trinodb/trino#1870.
Co-authored-by: Karol Sobczak karol.sobczak@karolsobczak.com