Rename version checking method for more clarity #18114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was observed that people are inclined to change version check behavior rather than stop calling that method when they maintain 3rd party plugins.
findepi
added
the
no-release-notes
github-actions
bot
added
tests:hive
hudi
hashhar
approved these changes
Jul 4, 2023
losipiuk
approved these changes
Jul 4, 2023
findepi
deleted the
findepi/rename-version-checking-method-for-more-clarity-9c7256
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was observed that people are inclined to change version check behavior rather than stop calling that method when they maintain 3rd party plugins.
Follows eg #18072