Relax SPI compatibility requirements

[ppalucha]

Description

Check only if major version matches when performing SPI version check.

Additional context and related issues

This change allows to test snapshot version of plugin against the released Trino version.

Release notes

( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
(x) Release notes are required, with the following suggested text:

# Section
* Relax SPI version check for plugins, so we can check snapshot plugins versions against the released Trino version.

[kokosing]

% comments

[kokosing]

assertFalse(Versions.checkMatch("420", "421"));
assertFalse(Versions.checkMatch("420", "421-SNAPSHOT"));

[ppalucha]

I messed it up, both no snapshots is already covered in previous test case. Should be good now.

[martint]

What's the use case for this?

[bitweld]

LGTM

[kokosing]

What's the use case for this?

@martint as stated in commit message This allows to test snapshot version of plugin against released Trino version.. This change allows 3rd party plugins (there are plenty of them in the wild) that are under development to use this check. Then once the plugins are released it is ensured that they are used with proper Trino version.

[martint]

I read that, but I don't understand how this helps third-party plugins. A third party plugin under development would be referencing a release version of Trino regardless of what version the plugin has (the version of the plugin is unrelated to Trino if it's not part of the Trino codebase). A plugin within the Trino tree would not have this problem, as its version would already match.

So the question I'm asking is what is the specific use case for this change, as it's not at all clear from the description.

[kokosing]

Thank you @martint for the feedback. I forced me to think me more about it. Actually with 3rd party plugins we cannot assume any versioning pattern. So relaxing this does not make much sense. I think people should not use this function outside of Trino.

[findepi]

A 3rd party plugin with specific versioning compatibility should not invoke Versions.checkSpiVersion