Skip to content

Fix broken release process#18019

Merged
martint merged 1 commit intotrinodb:masterfrom
martint:fix-release
Jun 22, 2023
Merged

Fix broken release process#18019
martint merged 1 commit intotrinodb:masterfrom
martint:fix-release

Conversation

@martint
Copy link
Copy Markdown
Member

@martint martint commented Jun 22, 2023

The release fails with:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-release-plugin:2.5:prepare (default-cli) on project trino-root: The artifact (io.trino:trino-jdbc) requires a different version (420) than what is found (${project.version}) for the expression (dep.presto-jdbc-under-test) in the project (io.trino:trino-test-jdbc-compatibility-old-driver). -> [Help 1]

This reverts commit 56083aa (#17642)

Release notes

(x) This is not user-visible or docs only and no release notes are required.

Copy link
Copy Markdown
Member

@kokosing kokosing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it a revert of 56083aa? Maybe we should add this information to commit message?

@kokosing
Copy link
Copy Markdown
Member

Thank you @wendigo for giving me a context

@martint
Copy link
Copy Markdown
Member Author

martint commented Jun 22, 2023

Is it a revert of 56083aa? Maybe we should add this information to commit message?

Yes, the information is already in the commit message.

The release fails with:

    [ERROR] Failed to execute goal org.apache.maven.plugins:maven-release-plugin:2.5:prepare (default-cli) on project trino-root: The artifact (io.trino:trino-jdbc) requires a different version (420) than what is found (${project.version}) for the expression (dep.presto-jdbc-under-test) in the project (io.trino:trino-test-jdbc-compatibility-old-driver). -> [Help 1]

This reverts commit 56083aa.
@martint martint merged commit 0ec6d95 into trinodb:master Jun 22, 2023
@martint martint deleted the fix-release branch June 22, 2023 17:52
@github-actions github-actions bot added this to the 420 milestone Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants