Skip to content

Refer ${project.version} instead of hardcoded version in trino-test-jdbc-compatibility-old-driver pom.xml#17642

Merged
ebyhr merged 1 commit intotrinodb:masterfrom
ankushChatterjee:refactor-jdbc-test-pom
Jun 6, 2023
Merged

Refer ${project.version} instead of hardcoded version in trino-test-jdbc-compatibility-old-driver pom.xml#17642
ebyhr merged 1 commit intotrinodb:masterfrom
ankushChatterjee:refactor-jdbc-test-pom

Conversation

@ankushChatterjee
Copy link
Copy Markdown
Contributor

Description

The default value of dep.presto-jdbc-under-test is hardcoded to the current version. Instead ${project.version} can be used.

Additional context and related issues

Release notes

(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text:

@cla-bot
Copy link
Copy Markdown

cla-bot bot commented May 25, 2023

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Ankush Chatterjee.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@ankushChatterjee
Copy link
Copy Markdown
Contributor Author

Have emailed signed CLA.

@ankushChatterjee
Copy link
Copy Markdown
Contributor Author

CLA is now signed

@ebyhr
Copy link
Copy Markdown
Member

ebyhr commented Jun 1, 2023

@cla-bot check

@cla-bot
Copy link
Copy Markdown

cla-bot bot commented Jun 1, 2023

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Ankush Chatterjee.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@cla-bot
Copy link
Copy Markdown

cla-bot bot commented Jun 1, 2023

The cla-bot has been summoned, and re-checked this pull request!

@ebyhr
Copy link
Copy Markdown
Member

ebyhr commented Jun 1, 2023

Could you fix the commit author? Also, please shorten the commit title.
https://github.com/trinodb/trino/blob/master/.github/DEVELOPMENT.md#format-git-commit-messages

@cla-bot
Copy link
Copy Markdown

cla-bot bot commented Jun 1, 2023

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Ankush Chatterjee.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

1 similar comment
@cla-bot
Copy link
Copy Markdown

cla-bot bot commented Jun 1, 2023

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Ankush Chatterjee.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@ankushChatterjee ankushChatterjee force-pushed the refactor-jdbc-test-pom branch from e0ca42c to a0673f9 Compare June 1, 2023 11:23
@cla-bot cla-bot bot added the cla-signed label Jun 1, 2023
Refer ${project.version} instead of hardcoded version for dep.presto-jdbc-under-test default value.
@ankushChatterjee ankushChatterjee force-pushed the refactor-jdbc-test-pom branch from 4a79583 to 647f81f Compare June 6, 2023 10:30
@ankushChatterjee
Copy link
Copy Markdown
Contributor Author

Have rebased the change. @ebyhr can this be merged?

@ebyhr ebyhr merged commit 56083aa into trinodb:master Jun 6, 2023
@github-actions github-actions bot added this to the 420 milestone Jun 6, 2023
@ankushChatterjee ankushChatterjee deleted the refactor-jdbc-test-pom branch June 7, 2023 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants