Revert optimization to reorder columns in parquet writer#17978
Merged
raunaqmorarka merged 1 commit intotrinodb:masterfrom Jun 21, 2023
Merged
Revert optimization to reorder columns in parquet writer#17978raunaqmorarka merged 1 commit intotrinodb:masterfrom
raunaqmorarka merged 1 commit intotrinodb:masterfrom
Conversation
Contributor
|
Attaching zipped version of the problematic Parquet file retrieved from the original Slack discussion: 20230620_084514_00081_uva2j-f9aec2f4-825d-4f2a-af24-414e1cfdb404.zip |
sopel39
approved these changes
Jun 20, 2023
Some files produced by this optimization were ignored by Apache Spark. Some versions of Databricks Runtime produce an exception when reading files with re-ordered columns.
raunaqmorarka
force-pushed
the
pqw-revert
branch
from
071481d to
45efa29
Compare
Closed
raunaqmorarka
added a commit
to raunaqmorarka/presto
that referenced
this pull request
Jun 26, 2023
Reproduces the problem fixed by trinodb#17978 by using CTAS on an existing file which reliably reproduced the problem and then attempting to read the resulting table through Apache Hive and Spark
raunaqmorarka
added a commit
that referenced
this pull request
Jun 27, 2023
Reproduces the problem fixed by #17978 by using CTAS on an existing file which reliably reproduced the problem and then attempting to read the resulting table through Apache Hive and Spark
nelsonspark
pushed a commit
to nelsonspark/trino
that referenced
this pull request
Jun 30, 2023
Reproduces the problem fixed by trinodb#17978 by using CTAS on an existing file which reliably reproduced the problem and then attempting to read the resulting table through Apache Hive and Spark
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Some files produced by this optimization were ignored by Apache Spark.
Related to https://trinodb.slack.com/archives/CGB0QHWSW/p1687254718875619
Some versions of Databricks Runtime produce an exception when reading files with re-ordered columns.
Related to https://trinodb.slack.com/archives/CP1MUNEUX/p1685685945379909
Additional context and related issues
Original PR #17404
The files produced after this change were found to be sometimes ignored by Apache Spark
and produce exceptions on DBR 12.2 LTS.
Apache Hive and trino parquet reader did not have problems reading any of the new files.
Release notes
( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
(x) Release notes are required, with the following suggested text: