Group small columns together in parquet files#17404
Merged
raunaqmorarka merged 1 commit intotrinodb:masterfrom May 9, 2023
Merged
Group small columns together in parquet files#17404raunaqmorarka merged 1 commit intotrinodb:masterfrom
raunaqmorarka merged 1 commit intotrinodb:masterfrom
Conversation
Modified parquet writer to store columns in order of their size inside row groups so that the reader can fetch small columns in fewer filesystem requests
sopel39
approved these changes
May 9, 2023
Member
sopel39
left a comment
There was a problem hiding this comment.
Do you think it might drop performance in some scenarios?
E.g. it seems optimally it should group columns that are mostly used together
Member
Author
This change matters only for columns with size less than |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Modified parquet writer to store columns in order of their size inside row groups
so that the reader can fetch small columns in fewer filesystem requests
Additional context and related issues
Based on similar logic in ORC writer at
trino/lib/trino-orc/src/main/java/io/trino/orc/OrcWriter.java
Line 420 in a13e451
Release notes
( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
(x) Release notes are required, with the following suggested text: