Skip to content

Support RLE DictionaryBlock.dictionary in UnnestingPositionsAppender #17844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
raunaqmorarka merged 3 commits into from
Jun 13, 2023
Merged

Support RLE DictionaryBlock.dictionary in UnnestingPositionsAppender #17844

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d5bf30c
Fix comment referencing old UnnestingPositionsAppender name
lukasz-stec Jun 12, 2023
4d66b8a
Add an error message to `append` precondition
lukasz-stec Jun 12, 2023
a444950
Support RLE DictionaryBlock.dictionary in UnnestingPositionsAppender
lukasz-stec Jun 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions core/trino-main/src/main/java/io/trino/operator/output/RleAwarePositionsAppender.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,9 @@ public RleAwarePositionsAppender(BlockPositionIsDistinctFrom isDistinctFromOpera
@Override
public void append(IntArrayList positions, Block source)
{
// RleAwarePositionsAppender should be used with FlatteningPositionsAppender that makes sure
// RleAwarePositionsAppender should be used with UnnestingPositionsAppender that makes sure
// append is called only with flat block
checkArgument(!(source instanceof RunLengthEncodedBlock));
checkArgument(!(source instanceof RunLengthEncodedBlock), "Append should be called with non-RLE block but got %s", source);
switchToFlat();
delegate.append(positions, source);
}
Expand Down
5 changes: 5 additions & 0 deletions core/trino-main/src/main/java/io/trino/operator/output/UnnestingPositionsAppender.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,11 @@ public long getSizeInBytes()
private void appendDictionary(IntArrayList positions, DictionaryBlock source)
{
Block dictionary = source.getDictionary();
if (dictionary instanceof RunLengthEncodedBlock rleDictionary) {
appendRle(rleDictionary.getValue(), positions.size());
return;
}

Copy link
Copy Markdown
Member

@raunaqmorarka raunaqmorarka Jun 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to create a test ?

Copy link
Copy Markdown
Member Author

@lukasz-stec lukasz-stec Jun 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is possible at the moment but it will be brittle as we don't want blocks like that so the test may stop covering this case at any time e.g. after #17842 is merged

IntArrayList dictionaryPositions = getDictionaryPositions(positions, source);
if (dictionaryBlockBuilder.canAppend(dictionary)) {
dictionaryBlockBuilder.append(dictionaryPositions, dictionary);
Expand Down