Support RLE DictionaryBlock.dictionary in UnnestingPositionsAppender#17844
Merged
raunaqmorarka merged 3 commits intotrinodb:masterfrom Jun 13, 2023
Merged
Conversation
core/trino-main/src/main/java/io/trino/operator/output/RleAwarePositionsAppender.java
Outdated
Show resolved
Hide resolved
Member
There was a problem hiding this comment.
Is it possible to create a test ?
Member
Author
There was a problem hiding this comment.
It is possible at the moment but it will be brittle as we don't want blocks like that so the test may stop covering this case at any time e.g. after #17842 is merged
lukasz-stec
force-pushed
the
ls/2306/01-unnest-dict-rle
branch
from
1f20d0b to
11a2b58
Compare
raunaqmorarka
approved these changes
Jun 12, 2023
core/trino-main/src/main/java/io/trino/operator/output/RleAwarePositionsAppender.java
Outdated
Show resolved
Hide resolved
DictionaryBlock.dictionary will not be RLE in normal circumstances, but since there is no precondition in the constructor, we cannot rely on this to be always the case
lukasz-stec
force-pushed
the
ls/2306/01-unnest-dict-rle
branch
from
11a2b58 to
a444950
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
DictionaryBlock.dictionarywill not be RLE in normal circumstances,but since there is no precondition in the constructor, we cannot
rely on this to be always the case
Additional context and related issues
Fixes #17861
Release notes
( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
(x) Release notes are required, with the following suggested text: