Skip to content

Use config default for determine_partition_count_for_write_enabled #17769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sopel39 merged 1 commit into from
Jun 6, 2023
Merged

Use config default for determine_partition_count_for_write_enabled #17769

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/trino-main/src/main/java/io/trino/SystemSessionProperties.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,7 @@ public SystemSessionProperties(
booleanProperty(
DETERMINE_PARTITION_COUNT_FOR_WRITE_ENABLED,
"Determine the number of partitions based on amount of data read and processed by the query for write queries",
false,
queryManagerConfig.isDeterminePartitionCountForWriteEnabled(),
Copy link
Copy Markdown
Member

@raunaqmorarka raunaqmorarka Jun 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there should be a test that verifies changes to plan based on usage of this session property.

Copy link
Copy Markdown
Member Author

@sopel39 sopel39 Jun 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

possibly, but in this PR I'm just plugging correct property so that users have session properties consistent with feature config

Copy link
Copy Markdown
Member

@losipiuk losipiuk Jun 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc: @linzebing

Copy link
Copy Markdown
Member

@linzebing linzebing Jun 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@raunaqmorarka : turning it on might cause OOM regressions related to partition writes. We do have it enabled for FTE internally while keeping lower bound of partitions to be 50.

false),
integerProperty(
MAX_HASH_PARTITION_COUNT,
Expand Down