Use config default for determine_partition_count_for_write_enabled#17769
Use config default for determine_partition_count_for_write_enabled#17769sopel39 merged 1 commit intotrinodb:masterfrom
Conversation
sopel39
added
the
no-release-notes
raunaqmorarka
left a comment
raunaqmorarka
left a comment
There was a problem hiding this comment.
Is query.determine-partition-count-for-write-enabled in the right place at QueryManagerConfig ?
It looks like this should be in OptimizerConfig.
Why is it disabled by default given that DeterminePartitionCount is enabled by default for non-write cases ?
| DETERMINE_PARTITION_COUNT_FOR_WRITE_ENABLED, | ||
| "Determine the number of partitions based on amount of data read and processed by the query for write queries", | ||
| false, | ||
| queryManagerConfig.isDeterminePartitionCountForWriteEnabled(), |
There was a problem hiding this comment.
I think there should be a test that verifies changes to plan based on usage of this session property.
There was a problem hiding this comment.
possibly, but in this PR I'm just plugging correct property so that users have session properties consistent with feature config
There was a problem hiding this comment.
@raunaqmorarka : turning it on might cause OOM regressions related to partition writes. We do have it enabled for FTE internally while keeping lower bound of partitions to be 50.
One of the reasons is distributing partition writers across more drivers within cluster so that memory limit is not breached. |
4 participants
No description provided.