Skip to content

Fix current_timestamp failure due to improper rounding #17455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2023
Merged

Fix current_timestamp failure due to improper rounding #17455

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions core/trino-main/src/main/java/io/trino/type/DateTimes.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -648,10 +648,13 @@ public static LongTimestampWithTimeZone longTimestampWithTimeZone(long precision
{
Copy link
Member

@kokosing kokosing May 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No tests?

Copy link
Member Author

@martint martint May 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#17511

Copy link
Member

@kokosing kokosing May 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! :)

checkArgument(precision <= TimestampWithTimeZoneType.MAX_PRECISION, "Precision is out of range");

return LongTimestampWithTimeZone.fromEpochMillisAndFraction(
start.toEpochMilli(),
(int) round((start.getNano() % NANOSECONDS_PER_MILLISECOND) * PICOSECONDS_PER_NANOSECOND, (int) (TimestampWithTimeZoneType.MAX_PRECISION - precision)),
timeZoneKey);
long epochMilli = start.toEpochMilli();
int picosOfMilli = (int) round((start.getNano() % NANOSECONDS_PER_MILLISECOND) * PICOSECONDS_PER_NANOSECOND, (int) (TimestampWithTimeZoneType.MAX_PRECISION - precision));
if (picosOfMilli == PICOSECONDS_PER_MILLISECOND) {
epochMilli++;
picosOfMilli = 0;
}
return LongTimestampWithTimeZone.fromEpochMillisAndFraction(epochMilli, picosOfMilli, timeZoneKey);
}

public static LongTimestampWithTimeZone longTimestampWithTimeZone(long epochSecond, long fractionInPicos, ZoneId zoneId)
Expand Down