Fix current_timestamp failure due to improper rounding #17455
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the number of nanoseconds in the current instant is such that it needs to round up to the nearest millisecond, the calculation doesn't properly compute the carryover.
vlad-lyutenko
approved these changes
May 11, 2023
hashhar
approved these changes
May 12, 2023
Member
Author
|
CI hit #16933 |
kokosing
reviewed
May 15, 2023
| } | ||
|
|
||
| public static LongTimestampWithTimeZone longTimestampWithTimeZone(long precision, Instant start, TimeZoneKey timeZoneKey) | ||
| { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the number of nanoseconds in the current instant is such that it needs to round up to the nearest millisecond, the calculation doesn't properly compute the carryover.
Release notes
(x) Release notes are required, with the following suggested text: