Skip to content

Conversation

@krvikash
Copy link
Contributor

@krvikash krvikash commented May 2, 2023

No description provided.

@cla-bot cla-bot bot added the cla-signed label May 2, 2023
@krvikash krvikash requested a review from findinpath May 3, 2023 06:24
@ebyhr ebyhr requested a review from losipiuk May 3, 2023 06:47
}

@Test(invocationCount = INVOCATION_COUNT, dataProvider = "parallelTests")
@Test(dataProvider = "parallelTests")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good but maybe there was some TestNG weirdness, which explains why we had it.
@mwd410 @hashhar do you know maybe?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: It was changed from 3 in d46c349

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah - thanks. Looks like remainder - not needed any more

@losipiuk losipiuk merged commit 0f25c5e into trinodb:master May 3, 2023
@github-actions github-actions bot added this to the 416 milestone May 3, 2023
@krvikash krvikash deleted the cleanup-1 branch May 3, 2023 09:33
@colebow colebow added the no-release-notes This pull request does not require release notes entry label May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed no-release-notes This pull request does not require release notes entry

Development

Successfully merging this pull request may close these issues.

4 participants