Skip to content

Remove redundant invocation count in testParallel #17317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
losipiuk merged 1 commit into from
May 3, 2023
Merged

Remove redundant invocation count in testParallel #17317

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions testing/trino-testing/src/main/java/io/trino/testing/BaseFailureRecoveryTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,6 @@
public abstract class BaseFailureRecoveryTest
extends AbstractTestQueryFramework
{
protected static final int INVOCATION_COUNT = 1;
private static final Duration MAX_ERROR_DURATION = new Duration(5, SECONDS);
private static final Duration REQUEST_TIMEOUT = new Duration(5, SECONDS);
private static final int DEFAULT_MAX_PARALLEL_TEST_CONCURRENCY = 4;
Expand Down Expand Up @@ -209,7 +208,7 @@ public Object[][] parallelTests()
};
}

@Test(invocationCount = INVOCATION_COUNT, dataProvider = "parallelTests")
@Test(dataProvider = "parallelTests")
Copy link
Member

@losipiuk losipiuk May 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good but maybe there was some TestNG weirdness, which explains why we had it.
@mwd410 @hashhar do you know maybe?

Copy link
Member

@ebyhr ebyhr May 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: It was changed from 3 in d46c349

Copy link
Member

@losipiuk losipiuk May 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah - thanks. Looks like remainder - not needed any more

public final void testParallel(Runnable runnable)
{
try {
Expand Down