Skip to content

Conversation

@hashhar
Copy link
Member

@hashhar hashhar commented Apr 21, 2023

Description

Each individual CI job that we add has overhead of ~2m to ~4m. With
almost 50 CI jobs this adds up to 100m of overhead at minimum. Combining
related jobs together while still keeping the job duration under 30m
helps reduce this overhead.

Additional context and related issues

Follows #17163.

Release notes

(x) This is not user-visible or docs only and no release notes are required.

@cla-bot cla-bot bot added the cla-signed label Apr 21, 2023
@github-actions github-actions bot added delta-lake Delta Lake connector mongodb MongoDB connector labels Apr 21, 2023
hashhar added 2 commits April 23, 2023 11:24
Each individual CI job that we add has overhead of ~2m to ~4m. With
almost 50 CI jobs this adds up to 100m of overhead at minimum. Combining
related jobs together while still keeping the job duration under 30m
helps reduce this overhead.

This new combined job takes ~32m.
Each individual CI job that we add has overhead of ~2m to ~4m. With
almost 50 CI jobs this adds up to 100m of overhead at minimum. Combining
related jobs together while still keeping the job duration under 30m
helps reduce this overhead.

None of the new combined jobs take more than 30m.
@hashhar hashhar force-pushed the hashhar/more-ci-cleanup branch from 7ca0559 to fce42ad Compare April 23, 2023 05:54
@hashhar hashhar requested review from findepi and losipiuk April 23, 2023 05:55
@hashhar
Copy link
Member Author

hashhar commented Apr 24, 2023

CI hit #17185 and #13995

@hashhar hashhar force-pushed the hashhar/more-ci-cleanup branch from fce42ad to 8362d50 Compare April 24, 2023 05:01
@hashhar
Copy link
Member Author

hashhar commented Apr 24, 2023

I removed the last commit which combined testing/trino-faulttolerant-tests -Pdefault and testing/trino-faulttolerant-tests -Ptest-fault-tolerant-delta because none of the other jobs use an array for profile in the matrix. I'll introduce that in separate PR as I need to test it a bit more.

if: >-
matrix.modules != 'plugin/trino-singlestore'
&& ! (contains(matrix.modules, 'trino-delta-lake') && contains(matrix.profile, 'cloud-tests'))
&& ! (contains(matrix.modules, 'trino-delta-lake') && contains(matrix.profile, 'gcs-tests'))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GCS tests may have high variance in run times, since Github runners run in unspecified regions.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the cloud-tests run in different regions. BTW the combined runtime is much shorter than runtime of cloud-tests + gcs-tests since gcs-tests had a single test class which limited concurrent tests. So chances of crossing 30m is even lower. I'll however keep an eye on CI times for next few days for builds on master to make sure we don't regress.

Copy link
Member

@findepi findepi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

% GCS test variance concern

@hashhar hashhar merged commit a9aa9d0 into master Apr 25, 2023
@hashhar hashhar deleted the hashhar/more-ci-cleanup branch April 25, 2023 06:28
@github-actions github-actions bot added this to the 415 milestone Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed delta-lake Delta Lake connector mongodb MongoDB connector

Development

Successfully merging this pull request may close these issues.

5 participants