Skip to content

Commit a9aa9d0

Browse files
hashharhashhar
committed
Remove dedicated fte-tests profile for most connectors
Each individual CI job that we add has overhead of ~2m to ~4m. With almost 50 CI jobs this adds up to 100m of overhead at minimum. Combining related jobs together while still keeping the job duration under 30m helps reduce this overhead. None of the new combined jobs take more than 30m.
1 parent 21ecbfa commit a9aa9d0

File tree

5 files changed

+0
-160
lines changed

5 files changed

+0
-160
lines changed

‎.github/workflows/ci.yml‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -566,22 +566,18 @@ jobs:
566566
- { modules: plugin/trino-kudu }
567567
- { modules: plugin/trino-mariadb }
568568
- { modules: plugin/trino-mongodb }
569-
- { modules: plugin/trino-mongodb, profile: fte-tests }
570569
- { modules: plugin/trino-mysql }
571-
- { modules: plugin/trino-mysql, profile: fte-tests }
572570
- { modules: plugin/trino-oracle }
573571
- { modules: plugin/trino-phoenix5 }
574572
- { modules: plugin/trino-pinot }
575573
- { modules: plugin/trino-postgresql }
576-
- { modules: plugin/trino-postgresql, profile: fte-tests }
577574
- { modules: plugin/trino-raptor-legacy }
578575
- { modules: plugin/trino-redis }
579576
- { modules: plugin/trino-redshift }
580577
- { modules: plugin/trino-redshift, profile: cloud-tests }
581578
- { modules: plugin/trino-redshift, profile: fte-tests }
582579
- { modules: plugin/trino-singlestore }
583580
- { modules: plugin/trino-sqlserver }
584-
- { modules: plugin/trino-sqlserver, profile: fte-tests }
585581
- { modules: testing/trino-faulttolerant-tests, profile: default }
586582
- { modules: testing/trino-faulttolerant-tests, profile: test-fault-tolerant-delta }
587583
- { modules: testing/trino-faulttolerant-tests, profile: test-fault-tolerant-hive }

‎plugin/trino-mongodb/pom.xml‎

Lines changed: 0 additions & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -273,43 +273,4 @@
273273
</plugin>
274274
</plugins>
275275
</build>
276-
277-
<profiles>
278-
<profile>
279-
<id>default</id>
280-
<activation>
281-
<activeByDefault>true</activeByDefault>
282-
</activation>
283-
<build>
284-
<plugins>
285-
<plugin>
286-
<groupId>org.apache.maven.plugins</groupId>
287-
<artifactId>maven-surefire-plugin</artifactId>
288-
<configuration>
289-
<excludes>
290-
<exclude>**/Test*FailureRecoveryTest.java</exclude>
291-
</excludes>
292-
</configuration>
293-
</plugin>
294-
</plugins>
295-
</build>
296-
</profile>
297-
298-
<profile>
299-
<id>fte-tests</id>
300-
<build>
301-
<plugins>
302-
<plugin>
303-
<groupId>org.apache.maven.plugins</groupId>
304-
<artifactId>maven-surefire-plugin</artifactId>
305-
<configuration>
306-
<includes>
307-
<include>**/Test*FailureRecoveryTest.java</include>
308-
</includes>
309-
</configuration>
310-
</plugin>
311-
</plugins>
312-
</build>
313-
</profile>
314-
</profiles>
315276
</project>

‎plugin/trino-mysql/pom.xml‎

Lines changed: 0 additions & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -222,43 +222,4 @@
222222
<scope>test</scope>
223223
</dependency>
224224
</dependencies>
225-
226-
<profiles>
227-
<profile>
228-
<id>default</id>
229-
<activation>
230-
<activeByDefault>true</activeByDefault>
231-
</activation>
232-
<build>
233-
<plugins>
234-
<plugin>
235-
<groupId>org.apache.maven.plugins</groupId>
236-
<artifactId>maven-surefire-plugin</artifactId>
237-
<configuration>
238-
<excludes>
239-
<exclude>**/Test*FailureRecoveryTest.java</exclude>
240-
</excludes>
241-
</configuration>
242-
</plugin>
243-
</plugins>
244-
</build>
245-
</profile>
246-
247-
<profile>
248-
<id>fte-tests</id>
249-
<build>
250-
<plugins>
251-
<plugin>
252-
<groupId>org.apache.maven.plugins</groupId>
253-
<artifactId>maven-surefire-plugin</artifactId>
254-
<configuration>
255-
<includes>
256-
<include>**/Test*FailureRecoveryTest.java</include>
257-
</includes>
258-
</configuration>
259-
</plugin>
260-
</plugins>
261-
</build>
262-
</profile>
263-
</profiles>
264225
</project>

‎plugin/trino-postgresql/pom.xml‎

Lines changed: 0 additions & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -247,43 +247,4 @@
247247
<scope>test</scope>
248248
</dependency>
249249
</dependencies>
250-
251-
<profiles>
252-
<profile>
253-
<id>default</id>
254-
<activation>
255-
<activeByDefault>true</activeByDefault>
256-
</activation>
257-
<build>
258-
<plugins>
259-
<plugin>
260-
<groupId>org.apache.maven.plugins</groupId>
261-
<artifactId>maven-surefire-plugin</artifactId>
262-
<configuration>
263-
<excludes>
264-
<exclude>**/Test*FailureRecoveryTest.java</exclude>
265-
</excludes>
266-
</configuration>
267-
</plugin>
268-
</plugins>
269-
</build>
270-
</profile>
271-
272-
<profile>
273-
<id>fte-tests</id>
274-
<build>
275-
<plugins>
276-
<plugin>
277-
<groupId>org.apache.maven.plugins</groupId>
278-
<artifactId>maven-surefire-plugin</artifactId>
279-
<configuration>
280-
<includes>
281-
<include>**/Test*FailureRecoveryTest.java</include>
282-
</includes>
283-
</configuration>
284-
</plugin>
285-
</plugins>
286-
</build>
287-
</profile>
288-
</profiles>
289250
</project>

‎plugin/trino-sqlserver/pom.xml‎

Lines changed: 0 additions & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -237,43 +237,4 @@
237237
<scope>test</scope>
238238
</dependency>
239239
</dependencies>
240-
241-
<profiles>
242-
<profile>
243-
<id>default</id>
244-
<activation>
245-
<activeByDefault>true</activeByDefault>
246-
</activation>
247-
<build>
248-
<plugins>
249-
<plugin>
250-
<groupId>org.apache.maven.plugins</groupId>
251-
<artifactId>maven-surefire-plugin</artifactId>
252-
<configuration>
253-
<excludes>
254-
<exclude>**/Test*FailureRecoveryTest.java</exclude>
255-
</excludes>
256-
</configuration>
257-
</plugin>
258-
</plugins>
259-
</build>
260-
</profile>
261-
262-
<profile>
263-
<id>fte-tests</id>
264-
<build>
265-
<plugins>
266-
<plugin>
267-
<groupId>org.apache.maven.plugins</groupId>
268-
<artifactId>maven-surefire-plugin</artifactId>
269-
<configuration>
270-
<includes>
271-
<include>**/Test*FailureRecoveryTest.java</include>
272-
</includes>
273-
</configuration>
274-
</plugin>
275-
</plugins>
276-
</build>
277-
</profile>
278-
</profiles>
279240
</project>

0 commit comments

Comments
 (0)