Skip to content

Support Kerberos Ticket Cache for trino authentication #17080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vjain143 wants to merge 1 commit into from
Closed

Support Kerberos Ticket Cache for trino authentication #17080

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions core/trino-main/src/main/java/io/trino/server/security/KerberosAuthenticator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,12 +87,18 @@ public AppConfigurationEntry[] getAppConfigurationEntry(String name)
options.put("debug", "true");
}
if (config.getKeytab() != null) {
options.put("storeKey", "true");
options.put("useKeyTab", "true");
options.put("keyTab", config.getKeytab().getAbsolutePath());
}

if (config.getKeyCache() != null) {
options.put("useTicketCache", "true");
options.put("renewTGT", "true");
options.put("ticketCache", config.getKeyCache().getAbsolutePath());
}
options.put("isInitiator", "false");
options.put("useKeyTab", "true");
options.put("principal", servicePrincipal);
options.put("storeKey", "true");

return new AppConfigurationEntry[] {new AppConfigurationEntry(Krb5LoginModule.class.getName(), REQUIRED, options)};
}
Expand Down
15 changes: 15 additions & 0 deletions core/trino-main/src/main/java/io/trino/server/security/KerberosConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,12 @@
public class KerberosConfig
{
public static final String HTTP_SERVER_AUTHENTICATION_KRB5_KEYTAB = "http-server.authentication.krb5.keytab";
public static final String HTTP_SERVER_AUTHENTICATION_KRB5_KEYCACHE = "http-server.authentication.krb5.keycache";

private File kerberosConfig;
private String serviceName;
private File keytab;
private File keyCache;
private String principalHostname;
private KerberosNameType nameType = HOSTBASED_SERVICE;
private Optional<String> userMappingPattern = Optional.empty();
Expand Down Expand Up @@ -79,6 +81,19 @@ public KerberosConfig setKeytab(File keytab)
return this;
}

@FileExists
public File getKeyCache()
{
return keyCache;
}

@Config("http-server.authentication.krb5.keycache")
public KerberosConfig setKeyCache(File keyCache)
{
this.keyCache = keyCache;
return this;
}

Copy link
Copy Markdown
Member

@Praveen2112 Praveen2112 Apr 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we apply some sort of a validation here so that we could either keyTab or credentialCache but not both, like how we do in hive connector.

public String getPrincipalHostname()
{
return principalHostname;
Expand Down