Skip to content

Support Kerberos Ticket Cache for trino authentication#17080

Closed
vjain143 wants to merge 1 commit intotrinodb:masterfrom
vjain143:kerberoscache
Closed

Support Kerberos Ticket Cache for trino authentication#17080
vjain143 wants to merge 1 commit intotrinodb:masterfrom
vjain143:kerberoscache

Conversation

@vjain143
Copy link
Copy Markdown

Description

This pr is new feature for trino authentication using kerberos credential cache, trino only support key tab file based authentication , which if not support in large enterprises.

Additional context and related issues

Release notes

( ) One new property is introduce - 'http-server.authentication.krb5.keycache'

# Section
* Added kerberos credential cache support for authentication , Issue  12509

@cla-bot
Copy link
Copy Markdown

cla-bot bot commented Apr 17, 2023

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

Copy link
Copy Markdown
Member

@Praveen2112 Praveen2112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this. Can we have some test coverage for this PR. We could have a PTs Environment with credentialCache and config test for KerberosConfig . We did something similar for hive connector and we could apply similar restriction here ref : #13482

this.keyCache = keyCache;
return this;
}

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we apply some sort of a validation here so that we could either keyTab or credentialCache but not both, like how we do in hive connector.

@vjain143
Copy link
Copy Markdown
Author

Yeah, It's hard to have test setup for this. But I will look into this.

@Praveen2112
Copy link
Copy Markdown
Member

We do have PT Environment where we test kerberized hive - we could have another environment with credential cache

@github-actions
Copy link
Copy Markdown

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua

@github-actions github-actions bot added the stale label Jan 16, 2024
@mosabua
Copy link
Copy Markdown
Member

mosabua commented Jan 16, 2024

👋 @vjain143 @Praveen2112 - this PR has become inactive. If you're still interested in working on it, please let us know.

We're working on closing out old and inactive PRs, so if you're too busy or this has too many merge conflicts to be worth picking back up, we'll be making another pass to close it out in a few weeks.

@github-actions github-actions bot removed the stale label Jan 18, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 9, 2024

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua

@github-actions github-actions bot added the stale label Feb 9, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 1, 2024

Closing this pull request, as it has been stale for six weeks. Feel free to re-open at any time.

@github-actions github-actions bot closed this Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants