-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Fix testing file metastore for Hudi #17040
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
863acf2
Fix potential resource leak in TestDeltaLakePlugin
findepi a9f2aad
Fix indentation
findepi f9d3b26
Add helper method in TestDeltaLakePlugin
findepi 05e6751
Test Hudi plugin initialization
findepi b07f6e4
Test file metastore in plugin unit tests
findepi 0fa3f26
Fix testing file metastore for Hudi
findepi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
133 changes: 133 additions & 0 deletions
133
plugin/trino-hudi/src/test/java/io/trino/plugin/hudi/TestHudiPlugin.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,133 @@ | ||
| /* | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package io.trino.plugin.hudi; | ||
|
|
||
| import com.google.common.collect.ImmutableMap; | ||
| import io.airlift.bootstrap.ApplicationConfigurationException; | ||
| import io.trino.plugin.hive.HiveConfig; | ||
| import io.trino.spi.Plugin; | ||
| import io.trino.spi.connector.ConnectorFactory; | ||
| import io.trino.testing.TestingConnectorContext; | ||
| import org.testng.annotations.Test; | ||
|
|
||
| import java.util.Map; | ||
| import java.util.Optional; | ||
|
|
||
| import static com.google.common.collect.Iterables.getOnlyElement; | ||
| import static org.assertj.core.api.Assertions.assertThatThrownBy; | ||
|
|
||
| public class TestHudiPlugin | ||
| { | ||
| @Test | ||
| public void testCreateConnector() | ||
| { | ||
| ConnectorFactory factory = getConnectorFactory(); | ||
| factory.create("test", Map.of("hive.metastore.uri", "thrift://foo:1234"), new TestingConnectorContext()) | ||
| .shutdown(); | ||
| } | ||
|
|
||
| @Test | ||
| public void testCreateTestingConnector() | ||
| { | ||
| Plugin plugin = new TestingHudiPlugin(Optional.empty()); | ||
| ConnectorFactory factory = getOnlyElement(plugin.getConnectorFactories()); | ||
| factory.create("test", Map.of("hive.metastore.uri", "thrift://foo:1234"), new TestingConnectorContext()) | ||
| .shutdown(); | ||
| } | ||
|
|
||
| @Test | ||
| public void testTestingFileMetastore() | ||
| { | ||
| ConnectorFactory factory = getConnectorFactory(); | ||
| factory.create( | ||
| "test", | ||
| ImmutableMap.of( | ||
| "hive.metastore", "file", | ||
| "hive.metastore.catalog.dir", "/tmp"), | ||
| new TestingConnectorContext()) | ||
| .shutdown(); | ||
| } | ||
|
|
||
| @Test | ||
| public void testThriftMetastore() | ||
| { | ||
| ConnectorFactory factory = getConnectorFactory(); | ||
| factory.create( | ||
| "test", | ||
| Map.of( | ||
| "hive.metastore", "thrift", | ||
| "hive.metastore.uri", "thrift://foo:1234"), | ||
| new TestingConnectorContext()) | ||
| .shutdown(); | ||
| } | ||
|
|
||
| @Test | ||
| public void testGlueMetastore() | ||
| { | ||
| ConnectorFactory factory = getConnectorFactory(); | ||
| factory.create( | ||
| "test", | ||
| Map.of( | ||
| "hive.metastore", "glue", | ||
| "hive.metastore.glue.region", "us-east-2"), | ||
| new TestingConnectorContext()) | ||
| .shutdown(); | ||
|
|
||
| assertThatThrownBy(() -> factory.create( | ||
| "test", | ||
| Map.of( | ||
| "hive.metastore", "glue", | ||
| "hive.metastore.uri", "thrift://foo:1234"), | ||
| new TestingConnectorContext())) | ||
| .isInstanceOf(ApplicationConfigurationException.class) | ||
| .hasMessageContaining("Error: Configuration property 'hive.metastore.uri' was not used"); | ||
| } | ||
|
|
||
| @Test | ||
| public void testAlluxioMetastore() | ||
| { | ||
| ConnectorFactory factory = getConnectorFactory(); | ||
| assertThatThrownBy(() -> factory.create( | ||
| "test", | ||
| Map.of("hive.metastore", "alluxio"), | ||
| new TestingConnectorContext())) | ||
| .hasMessageMatching("(?s)Unable to create injector, see the following errors:.*" + | ||
| "Explicit bindings are required and HiveMetastoreFactory .* is not explicitly bound.*"); | ||
|
|
||
| assertThatThrownBy(() -> factory.create( | ||
| "test", | ||
| Map.of("hive.metastore", "alluxio-deprecated"), | ||
| new TestingConnectorContext())) | ||
| // TODO: this should fail cleanly. We do not plan to support Alluxio metastore with Hudi | ||
| .hasStackTraceContaining("Cannot invoke \"String.split(String, int)\" because \"addr\" is null"); | ||
| } | ||
|
|
||
| @Test | ||
| public void testHiveConfigIsNotBound() | ||
| { | ||
| ConnectorFactory factory = getConnectorFactory(); | ||
| assertThatThrownBy(() -> factory.create("test", | ||
| Map.of( | ||
| "hive.metastore.uri", "thrift://foo:1234", | ||
| // Try setting any property provided by HiveConfig class | ||
| HiveConfig.CONFIGURATION_HIVE_PARTITION_PROJECTION_ENABLED, "true"), | ||
| new TestingConnectorContext())) | ||
| .hasMessageContaining("Error: Configuration property 'hive.partition-projection-enabled' was not used"); | ||
| } | ||
|
|
||
| private static ConnectorFactory getConnectorFactory() | ||
| { | ||
| return getOnlyElement(new HudiPlugin().getConnectorFactories()); | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: you could have added that in previous commit; just marked as ignored with comment.
And here just fix and unignore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agreed. or i could add it as a failing test, showing failure, and then showing the fix.
i think it doesn't matter for the long-term, and don't want to overload the CI queue, so will merge as is