Fix testing file metastore for Hudi#17040
Merged
findepi merged 6 commits intotrinodb:masterfrom Apr 17, 2023
Merged
Conversation
Add TestHudiPlugin.
It's useful in tests, so make sure it doesn't break.
findepi
added
the
no-release-notes
findepi
requested review from
alexjo2144,
ebyhr,
electrum,
findinpath and
losipiuk
github-actions
bot
added
delta-lake
losipiuk
reviewed
Apr 15, 2023
| .shutdown(); | ||
| } | ||
|
|
||
| @Test |
Member
There was a problem hiding this comment.
nit: you could have added that in previous commit; just marked as ignored with comment.
And here just fix and unignore.
Member
Author
There was a problem hiding this comment.
agreed. or i could add it as a failing test, showing failure, and then showing the fix.
i think it doesn't matter for the long-term, and don't want to overload the CI queue, so will merge as is
losipiuk
approved these changes
Apr 15, 2023
ebyhr
approved these changes
Apr 16, 2023
findinpath
approved these changes
Apr 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.