Skip to content

Remove filtering of unsupported column names in Delta #16992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ebyhr merged 1 commit into from
Apr 13, 2023
Merged

Remove filtering of unsupported column names in Delta #16992

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 0 additions & 18 deletions ...o-delta-lake/src/test/java/io/trino/plugin/deltalake/BaseDeltaLakeMinioConnectorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@

import com.google.common.base.Stopwatch;
import com.google.common.collect.ImmutableMap;
import com.google.common.collect.ImmutableSet;
import io.airlift.units.DataSize;
import io.trino.Session;
import io.trino.execution.QueryInfo;
Expand Down Expand Up @@ -204,23 +203,6 @@ protected Optional<DataMappingTestSetup> filterDataMappingSmokeTestData(DataMapp
return Optional.of(dataMappingTestSetup);
}

@Override
protected Optional<String> filterColumnNameTestData(String columnName)
Copy link
Copy Markdown
Member

@ebyhr ebyhr Apr 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have column name tests with none column mapping mode in product tests? I remember there's TestDeltaLakeColumnMappingMode#testSpecialCharacterColumnNamesWithColumnMappingMode for id and name mappings, but I'm not sure about existing none mapping tests.

As you know, we create tables and verify the result by ourselves in BaseDeltaLakeMinioConnectorTest, so it doesn't guarantee whether the column is accessible from Databricks or OSS Delta Lake.

Removing this override itself is fine.

Copy link
Copy Markdown
Member Author

@pajaks pajaks Apr 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot find any. It would be good follow up I guess.

{
// TODO https://github.com/trinodb/trino/issues/11297: these should be cleanly rejected and filterColumnNameTestData() replaced with isColumnNameRejected()
Set<String> unsupportedColumnNames = ImmutableSet.of(
"atrailingspace ",
" aleadingspace",
"a,comma",
"a;semicolon",
"a space");
if (unsupportedColumnNames.contains(columnName)) {
return Optional.empty();
}

return Optional.of(columnName);
}

@Override
protected TestTable createTableWithDefaultColumns()
{
Expand Down