Remove filtering of unsupported column names in Delta#16992
Merged
ebyhr merged 1 commit intotrinodb:masterfrom Apr 13, 2023
pajaks:pajaks/special_chars_in_column_names_tests
Merged
Remove filtering of unsupported column names in Delta#16992ebyhr merged 1 commit intotrinodb:masterfrom pajaks:pajaks/special_chars_in_column_names_tests
ebyhr merged 1 commit intotrinodb:masterfrom
pajaks:pajaks/special_chars_in_column_names_tests
Conversation
ebyhr
approved these changes
Apr 13, 2023
| } | ||
|
|
||
| @Override | ||
| protected Optional<String> filterColumnNameTestData(String columnName) |
Member
There was a problem hiding this comment.
Do we have column name tests with none column mapping mode in product tests? I remember there's TestDeltaLakeColumnMappingMode#testSpecialCharacterColumnNamesWithColumnMappingMode for id and name mappings, but I'm not sure about existing none mapping tests.
As you know, we create tables and verify the result by ourselves in BaseDeltaLakeMinioConnectorTest, so it doesn't guarantee whether the column is accessible from Databricks or OSS Delta Lake.
Removing this override itself is fine.
Member
Author
There was a problem hiding this comment.
I cannot find any. It would be good follow up I guess.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #11297
Release notes
(x) This is not user-visible or docs only and no release notes are required.