Skip to content

Add tests for trailing space in location for iceberg #16347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ebyhr merged 1 commit into from
Mar 4, 2023
Merged

Add tests for trailing space in location for iceberg #16347

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions ...in/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergConnectorSmokeTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,6 +307,38 @@ public void testRegisterTableWithMetadataFile()
assertUpdate(format("DROP TABLE %s", tableName));
}

@Test
public void testCreateTableWithTrailingSpaceInLocation()
{
String tableName = "test_create_table_with_trailing_space_" + randomNameSuffix();
String tableLocationWithTrailingSpace = schemaPath() + tableName + " ";

assertQuerySucceeds(format("CREATE TABLE %s WITH (location = '%s') AS SELECT 1 AS a, 'INDIA' AS b, true AS c", tableName, tableLocationWithTrailingSpace));
assertQuery("SELECT * FROM " + tableName, "VALUES (1, 'INDIA', true)");

assertThat(getTableLocation(tableName)).isEqualTo(tableLocationWithTrailingSpace);

assertUpdate("DROP TABLE " + tableName);
}

@Test
public void testRegisterTableWithTrailingSpaceInLocation()
{
String tableName = "test_create_table_with_trailing_space_" + randomNameSuffix();
String tableLocationWithTrailingSpace = schemaPath() + tableName + " ";

assertQuerySucceeds(format("CREATE TABLE %s WITH (location = '%s') AS SELECT 1 AS a, 'INDIA' AS b, true AS c", tableName, tableLocationWithTrailingSpace));

String registeredTableName = "test_register_table_with_trailing_space_" + randomNameSuffix();
assertUpdate(format("CALL system.register_table(CURRENT_SCHEMA, '%s', '%s')", registeredTableName, tableLocationWithTrailingSpace));
assertQuery("SELECT * FROM " + registeredTableName, "VALUES (1, 'INDIA', true)");

assertThat(getTableLocation(registeredTableName)).isEqualTo(tableLocationWithTrailingSpace);

assertUpdate("DROP TABLE " + registeredTableName);
dropTableFromMetastore(tableName);
}

@Test
public void testUnregisterTable()
{
Expand Down
7 changes: 7 additions & 0 deletions ...t/java/io/trino/plugin/iceberg/catalog/rest/TestIcebergRestCatalogConnectorSmokeTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,13 @@ public void testRegisterTableWithMetadataFile()
.hasMessageContaining("metadata location for register_table is not supported");
}

@Override
Comment thread
ebyhr marked this conversation as resolved.
Outdated
public void testRegisterTableWithTrailingSpaceInLocation()
{
assertThatThrownBy(super::testRegisterTableWithTrailingSpaceInLocation)
.hasMessageContaining("registerTable is not supported for Iceberg REST catalog");
}

@Override
public void testUnregisterTable()
{
Expand Down
9 changes: 9 additions & 0 deletions plugin/trino-iceberg/src/test/resources/hdp3.1-core-site.xml.gcs-template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,15 @@
</description>
</property>

<property>
<name>fs.gs.path.encoding</name>
<value>uri-path</value>
<description>
Path codec used that used for decoding and encoding Cloud Storage object
paths. Valid path codecs are `legacy` and `uri-path`.
</description>
</property>

<property>
<name>google.cloud.auth.service.account.enable</name>
<value>true</value>
Expand Down