Add tests for trailing space in location for iceberg#16347
Merged
ebyhr merged 1 commit intotrinodb:masterfrom Mar 4, 2023
pajaks:pajaks/trailing_space_test_iceberg
Merged
Add tests for trailing space in location for iceberg#16347ebyhr merged 1 commit intotrinodb:masterfrom pajaks:pajaks/trailing_space_test_iceberg
ebyhr merged 1 commit intotrinodb:masterfrom
pajaks:pajaks/trailing_space_test_iceberg
Conversation
Member
Author
Member
|
/test-with-secrets sha=bb8e41aceb52d301114bfcf9a6fef62a4ff6e9cb |
pajaks
changed the title
|
The CI workflow run with tests that require additional secrets finished as failure: https://github.com/trinodb/trino/actions/runs/4316542219 |
ebyhr
approved these changes
Mar 3, 2023
...test/java/io/trino/plugin/iceberg/catalog/rest/TestIcebergRestCatalogConnectorSmokeTest.java
Outdated
Show resolved
Hide resolved
plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergConnectorSmokeTest.java
Outdated
Show resolved
Hide resolved
plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergConnectorSmokeTest.java
Outdated
Show resolved
Hide resolved
plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergConnectorSmokeTest.java
Outdated
Show resolved
Hide resolved
Member
I would include "Iceberg" to the commit title, e.g. Add Iceberg tests for trailing space in location |
Member
|
Could you fix checkstyle failure? |
Member
|
/test-with-secrets sha=5fd783a870e3d9b6d933da2ee3c7fea882af3b15 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Additional context and related issues
Release notes
(x) This is not user-visible or docs only and no release notes are required.