Skip to content

Refactor mock catalog init in BaseConnectorTest #15956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ebyhr merged 2 commits into from
Feb 14, 2023
+9 −4
Merged

Refactor mock catalog init in BaseConnectorTest #15956

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
72268b7
Refactor mock catalog init in BaseConnectorTest
jklamer Feb 2, 2023
99004bf
Empty
jklamer Feb 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions testing/trino-testing/src/main/java/io/trino/testing/BaseConnectorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,14 @@ public abstract class BaseConnectorTest
private final ConcurrentMap<String, Function<ConnectorSession, List<String>>> mockTableListings = new ConcurrentHashMap<>();

@BeforeClass
public void addMockCatalog()
public void initMockCatalog()
{
QueryRunner queryRunner = getQueryRunner();
queryRunner.installPlugin(buildMockConnectorPlugin());
queryRunner.createCatalog("mock_dynamic_listing", "mock", Map.of());
}

protected MockConnectorPlugin buildMockConnectorPlugin()
{
MockConnectorFactory connectorFactory = MockConnectorFactory.builder()
.withListSchemaNames(session -> ImmutableList.copyOf(mockTableListings.keySet()))
Expand All @@ -177,9 +184,7 @@ public void addMockCatalog()
.apply(session);
})
.build();
QueryRunner queryRunner = getQueryRunner();
queryRunner.installPlugin(new MockConnectorPlugin(connectorFactory));
queryRunner.createCatalog("mock_dynamic_listing", "mock", Map.of());
return new MockConnectorPlugin(connectorFactory);
}

/**
Expand Down