Refactor mock catalog init in BaseConnectorTest#15956
Merged
ebyhr merged 2 commits intotrinodb:masterfrom Feb 14, 2023
Merged
Conversation
jklamer
force-pushed
the
jklamer/MockConnectorInstallRefactor
branch
from
fb1b577 to
72268b7
Compare
findepi
approved these changes
Feb 6, 2023
jklamer
force-pushed
the
jklamer/MockConnectorInstallRefactor
branch
from
cda1d19 to
99004bf
Compare
Member
Author
|
@findepi should be good to go provided empty commits get purged |
ebyhr
approved these changes
Feb 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactor the mock connector init process to be more flexible to different types of overriding by dependent test classes. Will allow dependent classes to decide when, what, and how they install in the mock connector plugin with most code reuse.
Additional context and related issues
Release notes
( X) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: