Skip to content

Limit concurrency of parallel FTE tests execution #15947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
losipiuk merged 1 commit into from
Feb 7, 2023
Merged

Limit concurrency of parallel FTE tests execution #15947

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion testing/trino-testing/src/main/java/io/trino/testing/BaseFailureRecoveryTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
import java.util.Optional;
import java.util.OptionalInt;
import java.util.UUID;
import java.util.concurrent.Semaphore;
import java.util.concurrent.ThreadLocalRandom;
import java.util.function.Consumer;
import java.util.function.Function;
Expand Down Expand Up @@ -74,8 +75,10 @@ public abstract class BaseFailureRecoveryTest
protected static final int INVOCATION_COUNT = 1;
private static final Duration MAX_ERROR_DURATION = new Duration(5, SECONDS);
private static final Duration REQUEST_TIMEOUT = new Duration(5, SECONDS);
private static final int MAX_PARALLEL_TEST_CONCURRENCY = 4;

private final RetryPolicy retryPolicy;
private final Semaphore parallelTestsSemaphore = new Semaphore(MAX_PARALLEL_TEST_CONCURRENCY);

protected BaseFailureRecoveryTest(RetryPolicy retryPolicy)
{
Expand Down Expand Up @@ -197,7 +200,24 @@ public Object[][] parallelTests()
@Test(invocationCount = INVOCATION_COUNT, dataProvider = "parallelTests")
public final void testParallel(Runnable runnable)
{
runnable.run();
try {
// By default, a test method using a @DataProvider with parallel attribute is run in 10 threads (org.testng.xml.XmlSuite#DEFAULT_DATA_PROVIDER_THREAD_COUNT).
// We limit number of concurrent test executions to prevent excessive resource usage.
//
// Note: the downside of this approach is that individual test runtimes will not be representative anymore
// as those will include time spent waiting for semaphore.
parallelTestsSemaphore.acquire();
}
catch (InterruptedException e) {
Thread.currentThread().interrupt();
throw new RuntimeException(e);
}
try {
runnable.run();
}
finally {
parallelTestsSemaphore.release();
}
}

protected void testCreateTable()
Expand Down