Limit concurrency of parallel FTE tests execution #15947
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
added
the
no-release-notes
losipiuk
force-pushed
the
lo/decrese-parallelism-fte-tests
branch
from
22dcaef to
b319c4a
Compare
findepi
approved these changes
Feb 2, 2023
Member
There was a problem hiding this comment.
Static vs instance.
If we have two classes within a suite, we should decide whether we want total limit, or per-class limit
(I am not advocating in any direction)
Member
Author
There was a problem hiding this comment.
Yeah - I know we have two options. I went with per-instance without any strong feeling that it is a better way.
testing/trino-testing/src/main/java/io/trino/testing/BaseFailureRecoveryTest.java
Outdated
Show resolved
Hide resolved
testing/trino-testing/src/main/java/io/trino/testing/BaseFailureRecoveryTest.java
Outdated
Show resolved
Hide resolved
linzebing
approved these changes
Feb 2, 2023
losipiuk
force-pushed
the
lo/decrese-parallelism-fte-tests
branch
from
b319c4a to
dc55670
Compare
losipiuk
force-pushed
the
lo/decrese-parallelism-fte-tests
branch
from
dc55670 to
f1dfea8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe fixes: #15809
Release notes
(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: