Merged
Conversation
ebyhr
approved these changes
Jan 25, 2023
Member
ebyhr
left a comment
ebyhr
left a comment
There was a problem hiding this comment.
The change itself is fine, but the PR title and commit message look different from the change.
mosabua
force-pushed
the
mosabua/bq-fte
branch
from
33d42e7 to
9a89915
Compare
mosabua
changed the title
Member
Author
|
Better now @ebyhr ? |
mosabua
changed the title
mosabua
force-pushed
the
mosabua/bq-fte
branch
from
9a89915 to
c730971
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
See title
Additional context and related issues
I ran into this when looking at #15620
Release notes
(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: