Conversation
|
/test-with-secrets a0db7441684de62e56d8e9a98a6d7428912fd1d7 |
|
/test-with-secrets sha=a0db7441684de62e56d8e9a98a6d7428912fd1d7 |
1 similar comment
|
/test-with-secrets sha=a0db7441684de62e56d8e9a98a6d7428912fd1d7 |
|
Here's the latest workflow run with secrets: https://github.com/trinodb/trino/actions/runs/3857770553 |
|
The CI workflow run with tests that require additional secrets finished as failure: https://github.com/trinodb/trino/actions/runs/3857770553 |
plugin/trino-bigquery/src/main/java/io/trino/plugin/bigquery/BigQueryPageSink.java
Outdated
Show resolved
Hide resolved
plugin/trino-bigquery/src/main/java/io/trino/plugin/bigquery/BigQueryMetadata.java
Outdated
Show resolved
Hide resolved
plugin/trino-bigquery/src/main/java/io/trino/plugin/bigquery/BigQueryMetadata.java
Outdated
Show resolved
Hide resolved
plugin/trino-bigquery/src/main/java/io/trino/plugin/bigquery/BigQueryMetadata.java
Outdated
Show resolved
Hide resolved
plugin/trino-bigquery/src/main/java/io/trino/plugin/bigquery/BigQueryMetadata.java
Outdated
Show resolved
Hide resolved
plugin/trino-bigquery/src/main/java/io/trino/plugin/bigquery/BigQueryMetadata.java
Outdated
Show resolved
Hide resolved
plugin/trino-bigquery/src/main/java/io/trino/plugin/bigquery/BigQueryMetadata.java
Outdated
Show resolved
Hide resolved
plugin/trino-bigquery/src/main/java/io/trino/plugin/bigquery/BigQueryMetadata.java
Outdated
Show resolved
Hide resolved
a0db744 to
ae199d1
Compare
|
/test-with-secrets sha=ae199d10b18460e09a7989b2e1e4097b274a1982 |
ebyhr
left a comment
There was a problem hiding this comment.
I would leave the final review & merge to @arhimondr @losipiuk
There was a problem hiding this comment.
nit: QueryJobConfiguration.of accepts a sql and build the object.
There was a problem hiding this comment.
schemaName is already remote schema name. Calling getRemoteSchemaName method is redundant.
There was a problem hiding this comment.
| private TableId createTable(BigQueryClient client, String projectId, String remoteSchemaName, String tableName, ImmutableList<Field> fields, Optional<String> tableComment) | |
| private TableId createTable(BigQueryClient client, String projectId, String datasetName, String tableName, List<Field> fields, Optional<String> tableComment) |
There was a problem hiding this comment.
BigQueryTableHandle#asPlainTable returns BigQueryNamedRelationHandle.
d3fe6c8 to
6fa0767
Compare
There was a problem hiding this comment.
nit: quote above vs quoted here looks kinda unnatural. I would keep name the same.
|
/test-with-secrets sha=6c5eb9f63905c55b99fc49e561c1cc95579063f6 |
|
/test-with-secrets sha=6fa0767cc2d96008f2876bfa307693c4a267d79f |
run in progress:https://github.com/trinodb/trino/actions/runs/3931242353 |
|
The CI workflow run with tests that require additional secrets finished as failure: https://github.com/trinodb/trino/actions/runs/3931242353 |
6fa0767 to
d8a1e6e
Compare
|
/test-with-secrets sha=d8a1e6e3a29aac958bd95ec5ce3f950d7e7c1cc4 |
d8a1e6e to
62b32d8
Compare
|
/test-with-secrets sha= 62b32d8cce2db86e290339d2c851b90985389009 |
|
/test-with-secrets sha=62b32d8cce2db86e290339d2c851b90985389009 |
|
The CI workflow run with tests that require additional secrets finished as failure: https://github.com/trinodb/trino/actions/runs/3960804172 |
62b32d8 to
d53a558
Compare
|
/test-with-secrets sha=d53a55847e0d026a9589374e773b5770ddc8a12a |
|
cancelled local CI as I am running version "with secrets". And we care about output of the latter. |
|
The CI workflow run with tests that require additional secrets finished as failure: https://github.com/trinodb/trino/actions/runs/3967428518 |
|
/test-with-secrets sha=d53a55847e0d026a9589374e773b5770ddc8a12a |
|
I got #15801 but it looks totally unrelated (it happens in different test job). merging. |
|
The CI workflow run with tests that require additional secrets finished as failure: https://github.com/trinodb/trino/actions/runs/3969882477 |
Description
This PR introduces FTE for BigQuery.
This differs slightly from previous FTE PRs in that the FailureRecoveryTests are executed within the
-Pcloud-tests, rather than a separate profile like the others. This may cause problems by running up against the 1 hour time limit, in which case, we'll have to separate the FailureRecoveryTests from cloud-tests.Additional context and related issues
Release notes
( ) This is not user-visible or docs only and no release notes are required.
(X) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: