Skip to content

Simplify disabled cache construction in CachingHiveMetastore #15846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
findepi wants to merge 1 commit into from
Closed

Simplify disabled cache construction in CachingHiveMetastore #15846

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 6 additions & 24 deletions ...n/trino-hive/src/main/java/io/trino/plugin/hive/metastore/cache/CachingHiveMetastore.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,16 +276,6 @@ protected CachingHiveMetastore(HiveMetastore delegate, OptionalLong expiresAfter
partitionCache = partitionCacheFactory.buildCache(this::loadPartitionByName, this::loadPartitionsByNames);
}

private static <K, V> LoadingCache<K, V> neverCache(com.google.common.base.Function<K, V> loader)
{
return buildCache(OptionalLong.of(0), OptionalLong.empty(), Optional.empty(), 0, StatsRecording.DISABLED, loader);
}

private static <K, V> LoadingCache<K, V> neverCache(Function<K, V> loader, Function<Iterable<K>, Map<K, V>> bulkLoader)
{
return buildCache(OptionalLong.of(0), 0, StatsRecording.DISABLED, loader, bulkLoader);
}

@Managed
public void flushCache()
{
Expand Down Expand Up @@ -1141,20 +1131,12 @@ public <K, V> LoadingCache<K, V> buildCache(com.google.common.base.Function<K, V

private static CacheFactory neverCacheFactory()
{
return new CacheFactory()
{
@Override
public <K, V> LoadingCache<K, V> buildCache(com.google.common.base.Function<K, V> loader)
{
return neverCache(loader);
}

@Override
public <K, V> LoadingCache<K, V> buildCache(com.google.common.base.Function<K, V> loader, Function<Iterable<K>, Map<K, V>> bulkLoader)
{
return neverCache(loader, bulkLoader);
Copy link
Copy Markdown
Member

@sopel39 sopel39 Jan 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neverCache are no longer used I think

}
};
return cacheFactory(
OptionalLong.of(0),
OptionalLong.empty(),
Optional.empty(),
0,
StatsRecording.DISABLED);
}

private static <K, V> LoadingCache<K, V> buildCache(
Expand Down