Simplify disabled cache construction in CachingHiveMetastore#15846
Closed
findepi wants to merge 1 commit intotrinodb:masterfrom
Closed
Conversation
findepi
added
the
no-release-notes
raunaqmorarka
approved these changes
Jan 25, 2023
sopel39
reviewed
Jan 25, 2023
plugin/trino-hive/src/main/java/io/trino/plugin/hive/metastore/cache/CachingHiveMetastore.java
Show resolved
Hide resolved
sopel39
approved these changes
Jan 25, 2023
sopel39
reviewed
Jan 25, 2023
| @Override | ||
| public <K, V> LoadingCache<K, V> buildCache(com.google.common.base.Function<K, V> loader, Function<Iterable<K>, Map<K, V>> bulkLoader) | ||
| { | ||
| return neverCache(loader, bulkLoader); |
Member
There was a problem hiding this comment.
neverCache are no longer used I think
Member
|
I've also cleaned it up as part of #15864 |
Member
Author
thank you! |
findepi
deleted the
findepi/simplify-disabled-cache-construction-in-cachinghivemetastore-c72053
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.