Skip to content

Test failure message when executing register_table procedure in Iceberg REST and JDBC catalogs #15806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ebyhr merged 2 commits into from
Jan 26, 2023
Merged

Test failure message when executing register_table procedure in Iceberg REST and JDBC catalogs #15806

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
34295bf
Enable register_table procedure in Iceberg REST tests
ebyhr Jan 23, 2023
96606a2
Improve error message for register_table in Iceberg JDBC catalog
ebyhr Jan 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...in/trino-iceberg/src/main/java/io/trino/plugin/iceberg/catalog/jdbc/TrinoJdbcCatalog.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ public Transaction newCreateTableTransaction(ConnectorSession session, SchemaTab
@Override
public void registerTable(ConnectorSession session, SchemaTableName tableName, String tableLocation, String metadataLocation)
{
jdbcCatalog.registerTable(TableIdentifier.of(tableName.getSchemaName(), tableName.getTableName()), metadataLocation);
throw new TrinoException(NOT_SUPPORTED, "registerTable is not supported for Iceberg JDBC catalogs");
}

@Override
Expand Down
18 changes: 6 additions & 12 deletions ...t/java/io/trino/plugin/iceberg/catalog/jdbc/TestIcebergJdbcCatalogConnectorSmokeTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ protected QueryRunner createQueryRunner()
.put("iceberg.catalog.type", "jdbc")
.put("iceberg.jdbc-catalog.connection-url", server.getJdbcUrl())
.put("iceberg.jdbc-catalog.catalog-name", "tpch")
.put("iceberg.register-table-procedure.enabled", "true")
.buildOrThrow())
.setInitialTables(REQUIRED_TPCH_TABLES)
.build();
Expand Down Expand Up @@ -97,42 +98,35 @@ protected String getMetadataLocation(String tableName)
public void testRegisterTableWithTableLocation()
{
assertThatThrownBy(super::testRegisterTableWithTableLocation)
.hasMessageContaining("register_table procedure is disabled");
.hasMessageContaining("registerTable is not supported for Iceberg JDBC catalogs");
}

@Override
public void testRegisterTableWithComments()
{
assertThatThrownBy(super::testRegisterTableWithComments)
.hasMessageContaining("register_table procedure is disabled");
.hasMessageContaining("registerTable is not supported for Iceberg JDBC catalogs");
}

@Override
public void testRegisterTableWithShowCreateTable()
{
assertThatThrownBy(super::testRegisterTableWithShowCreateTable)
.hasMessageContaining("register_table procedure is disabled");
.hasMessageContaining("registerTable is not supported for Iceberg JDBC catalogs");
}

@Override
public void testRegisterTableWithReInsert()
{
assertThatThrownBy(super::testRegisterTableWithReInsert)
.hasMessageContaining("register_table procedure is disabled");
}

@Override
public void testRegisterTableWithDroppedTable()
{
assertThatThrownBy(super::testRegisterTableWithDroppedTable)
.hasMessageContaining("register_table procedure is disabled");
.hasMessageContaining("registerTable is not supported for Iceberg JDBC catalogs");
}

@Override
public void testRegisterTableWithDifferentTableName()
{
assertThatThrownBy(super::testRegisterTableWithDifferentTableName)
.hasMessageContaining("register_table procedure is disabled");
.hasMessageContaining("registerTable is not supported for Iceberg JDBC catalogs");
}

@Override
Expand Down
18 changes: 6 additions & 12 deletions ...t/java/io/trino/plugin/iceberg/catalog/rest/TestIcebergRestCatalogConnectorSmokeTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ protected QueryRunner createQueryRunner()
.put("iceberg.file-format", format.name())
.put("iceberg.catalog.type", "rest")
.put("iceberg.rest-catalog.uri", testServer.getBaseUrl().toString())
.put("iceberg.register-table-procedure.enabled", "true")
.buildOrThrow())
.setInitialTables(REQUIRED_TPCH_TABLES)
.build();
Expand Down Expand Up @@ -119,42 +120,35 @@ protected String getMetadataLocation(String tableName)
public void testRegisterTableWithTableLocation()
{
assertThatThrownBy(super::testRegisterTableWithTableLocation)
.hasMessageContaining("register_table procedure is disabled");
.hasMessageContaining("registerTable is not supported for Iceberg REST catalog");
}

@Override
public void testRegisterTableWithComments()
{
assertThatThrownBy(super::testRegisterTableWithComments)
.hasMessageContaining("register_table procedure is disabled");
.hasMessageContaining("registerTable is not supported for Iceberg REST catalog");
}

@Override
public void testRegisterTableWithShowCreateTable()
{
assertThatThrownBy(super::testRegisterTableWithShowCreateTable)
.hasMessageContaining("register_table procedure is disabled");
.hasMessageContaining("registerTable is not supported for Iceberg REST catalog");
}

@Override
public void testRegisterTableWithReInsert()
{
assertThatThrownBy(super::testRegisterTableWithReInsert)
.hasMessageContaining("register_table procedure is disabled");
}

@Override
public void testRegisterTableWithDroppedTable()
{
assertThatThrownBy(super::testRegisterTableWithDroppedTable)
.hasMessageContaining("register_table procedure is disabled");
.hasMessageContaining("registerTable is not supported for Iceberg REST catalog");
}

@Override
public void testRegisterTableWithDifferentTableName()
{
assertThatThrownBy(super::testRegisterTableWithDifferentTableName)
.hasMessageContaining("register_table procedure is disabled");
.hasMessageContaining("registerTable is not supported for Iceberg REST catalog");
}

@Override
Expand Down